Wordpress fault in my sidebar (copyright bit)

[Dagz]

http://redwood-tints.co.uk/

Just noticed I've got a fault in my sidebar since the last update. I made the site myself a couple of years ago and am not a web designer. Is there an obvious fault here, or an easy solution?

<div class="side-box">
<ul id="copyrights">
<li>
<?php
global $wpdb;
$post_datetimes = $wpdb->get_row($wpdb->prepare("SELECT YEAR(min(post_date_gmt)) AS firstyear, YEAR(max(post_date_gmt)) AS lastyear FROM $wpdb->posts WHERE post_date_gmt > 1970"));
if ($post_datetimes) {
$firstpost_year = $post_datetimes->firstyear;
$lastpost_year = $post_datetimes->lastyear;
$copyright = __('Copyright &copy;&nbsp; ', 'piano-black') . $firstpost_year;
if($firstpost_year != $lastpost_year) {
$copyright .= '-'. $lastpost_year;
}
$copyright .= ' ';
echo $copyright;
}
?>
&nbsp;<a href="<?php echo get_option('home'); ?>/"><div class="org">Redwood Window Tinting</div></a></li>
<li><div class="adr">
<div class="street-address">111-117 St George's Road</div></li>
<li><span class="locality">Bristol</span></li>
<li><span class="postal-code">BS1 5UW</span></div></li>
</ul>
</div>

Thankyou.

 

[HFServices]

Seems like a problem with the theme using $wpdb->prepare in an insecure manner.

Another argument is a must in the $wpdb->prepare call (hence the error Missing argument 2)

Look on line 78 of sidebar.php for the theme you are using and change the code there.

If you can't do it then post the code for line 78 here.

Help is available on Wordpress here:

http://make.wordpress.org/core/2012/12/12/php-warning-missing-argument-2-for-wpdb-prepare/

 

[Faevilangel]

Can you PM me the login details and I will take a look but I am guessing it's down to the code posted above.

WP has been cleaning up it's system, and the code you're using in the sidebar is probably outdated, especially since 3.4 / 3.5 has some serious updates (minimum php 5 etc)

 

[marketing9]

Also,

if you update your WP and theme to the lastest, the problem generally self-corrects.

 

[Dagz]

Hmmmmm, pretty scared about changing the theme. Is it recommended even if I can sort the fault? Cos this theme has the perfect look for me. Also, never changed the theme before, surely that's got to end up creating new issues - can't be that simple can it?

Thanks

 

[Faevilangel]

No need to change the theme, what I think the poster meant was to install any updates to the theme that may be available (depends where you got the theme from etc).

My offer of looking at it still stands

 

[Alan]

If is just creating a from and to date for the copyright, which is a bit fancy but not that important.

You could just change it to copyright the current year rather than a date range and remove some database activity and speed you site up by a few micro seconds

<div class="side-box">
<ul id="copyrights">
<li>
<?php
$copyright = __('Copyright &copy;&nbsp; ', 'piano-black') . date('Y').' ';
echo $copyright;
}
?>
&nbsp;<a href="<?php echo get_option('home'); ?>/"><div class="org">Redwood Window Tinting</div></a></li>
<li><div class="adr">
<div class="street-address">111-117 St George's Road</div></li>
<li><span class="locality">Bristol</span></li>
<li><span class="postal-code">BS1 5UW</span></div></li>
</ul>
</div>

however if you want it to work exactly as is, with the database call just get rid of the $wpdb->prepare as it isn't preparing anything (which would be the second argument that is missing)

<div class="side-box">
<ul id="copyrights">
<li>
<?php
global $wpdb;
$post_datetimes = $wpdb->get_row("SELECT YEAR(min(post_date_gmt)) AS firstyear, YEAR(max(post_date_gmt)) AS lastyear FROM $wpdb->posts WHERE post_date_gmt > 1970");
if ($post_datetimes) {
$firstpost_year = $post_datetimes->firstyear;
$lastpost_year = $post_datetimes->lastyear;
$copyright = __('Copyright &copy;&nbsp; ', 'piano-black') . $firstpost_year;
if($firstpost_year != $lastpost_year) {
$copyright .= '-'. $lastpost_year;
}
$copyright .= ' ';
echo $copyright;
}
?>
&nbsp;<a href="<?php echo get_option('home'); ?>/"><div class="org">Redwood Window Tinting</div></a></li>
<li><div class="adr">
<div class="street-address">111-117 St George's Road</div></li>
<li><span class="locality">Bristol</span></li>
<li><span class="postal-code">BS1 5UW</span></div></li>
</ul>
</div>

 

[Dagz]

"Briefly unavailable for scheduled maintenance. Check back in a minute."

Bloody ell!

 

[Dagz]

Wow, thanks Roibot, that sorted it. I just cut and pasted the bottom one. Thanks

 

[Alan]

Glad to have helped.