PDA

View Full Version : Can someone help, I think it is simple.

broadband-engine
10th February 2005, 22:46
Hi

Can someone help, I think it is simple. I want to call the script that is currently in the head into the page from another file in order to tidy up the head section. Currently getting an error. Do I have to do something with the <body> tag if I am calling the script in???????


<html>
<head>
<title></title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<link href="---.css" rel="stylesheet" type="text/css">
<script language="JavaScript" type="text/JavaScript">
<!--
function MM_preloadImages() { //v3.0
var d=document; if(d.images){ if(!d.MM_p) d.MM_p=new Array();
var i,j=d.MM_p.length,a=MM_preloadImages.arguments; for(i=0; i<a.length; i++)
if (a[i].indexOf("#")!=0){ d.MM_p[j]=new Image; d.MM_p[j++].src=a[i];}}
}

function MM_swapImgRestore() { //v3.0
var i,x,a=document.MM_sr; for(i=0;a&&i<a.length&&(x=a[i])&&x.oSrc;i++) x.src=x.oSrc;
}

function MM_findObj(n, d) { //v4.01
var p,i,x; if(!d) d=document; if((p=n.indexOf("?"))>0&&parent.frames.length) {
d=parent.frames[n.substring(p+1)].document; n=n.substring(0,p);}
if(!(x=d[n])&&d.all) x=d.all[n]; for (i=0;!x&&i<d.forms.length;i++) x=d.forms[i][n];
for(i=0;!x&&d.layers&&i<d.layers.length;i++) x=MM_findObj(n,d.layers[i].document);
if(!x && d.getElementById) x=d.getElementById(n); return x;
}

function MM_swapImage() { //v3.0
var i,j=0,x,a=MM_swapImage.arguments; document.MM_sr=new Array; for(i=0;i<(a.length-2);i+=3)
if ((x=MM_findObj(a[i]))!=null){document.MM_sr[j++]=x ; if(!x.oSrc) x.oSrc=x.src; x.src=a[i+2];}
}
//-->
</script>
</head>

<body onLoad="MM_preloadImages('images/compare-credit-cards.jpg',
'images/compare-loans.jpg','images/compare-current-accounts.jpg',
'images/compare-savings-accounts.jpg','images/compare-utilities.jpg',
'images/compare-insurance.jpg','images/news.jpg')">



here is what the script is doing, it is swapping an image on mouseover.



<a href="http://www.quote-engine.com/compare-credit-cards.html" onMouseOver="MM_swapImage('Image1','','images/compare-credit-cards.jpg',1)" onMouseOut="MM_swapImgRestore()"> /images/compare-credit-cards1.jpg





Cheers
Phil
Ozzy
11th February 2005, 09:11
You need to close the <a> tag at the end of the URL and then open the image tag. Then the onMouseOver and MouseOut javascript is within the content of the <img> tag and not the <a> tag as it currently is. For example....

<a href="http://www.quote-engine.com/compare-credit-cards.html"> /images/compare-credit-cards1.jpg
</a>
paul1985
1st April 2005, 21:08
to remove the javascript from the page put the lines below into an external file eg myscript.js



<script language="JavaScript" type="text/JavaScript">
<!--
function MM_preloadImages() { //v3.0
var d=document; if(d.images){ if(!d.MM_p) d.MM_p=new Array();
var i,j=d.MM_p.length,a=MM_preloadImages.arguments; for(i=0; i<a.length; i++)
if (a[i].indexOf("#")!=0){ d.MM_p[j]=new Image; d.MM_p[j++].src=a[i];}}
}

function MM_swapImgRestore() { //v3.0
var i,x,a=document.MM_sr; for(i=0;a&&i<a.length&&(x=a[i])&&x.oSrc;i++) x.src=x.oSrc;
}

function MM_findObj(n, d) { //v4.01
var p,i,x; if(!d) d=document; if((p=n.indexOf("?"))>0&&parent.frames.length) {
d=parent.frames[n.substring(p+1)].document; n=n.substring(0,p);}
if(!(x=d[n])&&d.all) x=d.all[n]; for (i=0;!x&&i<d.forms.length;i++) x=d.forms[i][n];
for(i=0;!x&&d.layers&&i<d.layers.length;i++) x=MM_findObj(n,d.layers[i].document);
if(!x && d.getElementById) x=d.getElementById(n); return x;
}

function MM_swapImage() { //v3.0
var i,j=0,x,a=MM_swapImage.arguments; document.MM_sr=new Array; for(i=0;i<(a.length-2);i+=3)
if ((x=MM_findObj(a[i]))!=null){document.MM_sr[j++]=x ; if(!x.oSrc) x.oSrc=x.src; x.src=a[i+2];}
}
//-->
</script>


put the following lines in the html in its place

<SCRIPT LANGUAGE="JavaScript" SRC="myscript.js">
</SCRIPT>

all done